Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(ext/dynblock): recursive function call typo in detecting variables #686

Merged
merged 1 commit into from
Oct 8, 2024

Conversation

calmonr
Copy link
Contributor

@calmonr calmonr commented Jul 9, 2024

I'm studying HCL internals and when reading the docs for detecting variables in the dynblock package I got confused by the recursive function call but I noticed that for the depth-first, pre-order traversal the function name was wrong.

It's a small adjustment and I hope I can continue contributing more.

Thank you.

Copy link

hashicorp-cla-app bot commented Jul 9, 2024

CLA assistant check
All committers have signed the CLA.

Copy link

CLA assistant check

Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement

Learn more about why HashiCorp requires a CLA and what the CLA includes

Have you signed the CLA already but the status is still pending? Recheck it.

Copy link
Member

@liamcervante liamcervante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good find! Thanks for raising.

@liamcervante liamcervante merged commit 3883feb into hashicorp:main Oct 8, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants